lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6075) CoreAdminHandler should synchronize while adding a task to the tracking map
Date Mon, 19 May 2014 07:44:37 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001467#comment-14001467
] 

Shalin Shekhar Mangar commented on SOLR-6075:
---------------------------------------------

bq. The addTask(String map, TaskObject o, boolean limit) method reads in one statement and
removes in the next. That was the reason I thought we should synchronize it. 

I added a comment in the code to this effect. This lack of synchronization is not a problem
in this particular case because no one else removes from that map. You're right in the general
sense but why synchronize on Collections.synchronizedMap(...) instances? Remove one of those
synchronizations if you really want to go that way.

> CoreAdminHandler should synchronize while adding a task to the tracking map
> ---------------------------------------------------------------------------
>
>                 Key: SOLR-6075
>                 URL: https://issues.apache.org/jira/browse/SOLR-6075
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>            Priority: Minor
>             Fix For: 4.9, 5.0
>
>         Attachments: SOLR-6075.patch, SOLR-6075.patch
>
>
> CoreAdminHandler should synchronize on the tracker maps when adding a task. It's a rather
nasty bug and we should get this in asap.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message