lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5673) MmapDirectory shouldn't pass along OOM wrapped as IOException
Date Fri, 16 May 2014 11:24:52 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998706#comment-13998706
] 

Robert Muir commented on LUCENE-5673:
-------------------------------------

I think its a good start but we need to be careful here.

First of all my problem is with the "OutOfMemoryError" text. I do still think the message
should start with "Map failed" instead of "Memory mapping failed". We want users to be able
to google the error and still find some assistance.

If we are going to offer more explanation in addition to that, it woudl be good to try to
add practical stuff: e.g. mention 'ulimit' and 'sysctl vm.max_map_count' and so on.

> MmapDirectory shouldn't pass along OOM wrapped as IOException
> -------------------------------------------------------------
>
>                 Key: LUCENE-5673
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5673
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5673.patch
>
>
> The bug here is in java (not MMapDir), but i think we shoudl do something.
> Users get confused when they configure their JVM to trigger something on OOM, and then
see "OutOfMemoryError: Map Failed": but their trigger doesnt fire.
> Thats because in the jdk, when it maps files it catches OutOfMemoryError, asks for a
garbage collection, sleeps for 100 milliseconds, then tries to map again. if it fails a second
time it wraps the OOM in a generic IOException.
> I think we should add a try/catch to our filechannel.map



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message