lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5678) Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput
Date Sat, 17 May 2014 20:43:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000867#comment-14000867
] 

Michael McCandless commented on LUCENE-5678:
--------------------------------------------

I tested index time for full Wikipedia; it's output intensive, and it looks like no perf change
w/ the patch, though the numbers are a little noisy from run to run ...

> Investigate to use FileoutputStream instead of RandomAccessFile in FSIndexOutput
> --------------------------------------------------------------------------------
>
>                 Key: LUCENE-5678
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5678
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/store
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-5678.patch
>
>
> We no longer allow seeking in IndexOutput, so there is no need to use RandomAccessFile.
We can change this with a < 1 KiB patch.
> Further improvements would be to merge this with OutputStreamIndexOutput, so we get many
simplifications.
> There is also no reason anymore to separate DataOutput from IndexOutput. The only additional
thing is IndexOutput#getFilePointer(), which is handled by  an internal counter (does not
use getFilePointer of the underlying RAF) and checksums.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message