lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5683) Improve SegmentReader.getXXXDocValues
Date Thu, 22 May 2014 17:37:03 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006173#comment-14006173
] 

Robert Muir commented on LUCENE-5683:
-------------------------------------

Sorry, I definitely see it as an inefficiency. This is easy to fix. I'll take the issue.

We shouldnt let segmentreader be slow. It was part of the design to not make pulling a docvalues
expensive, because otherwise it makes it too hard to use (it is the same thing we fixed for
reusing fields in indexwriter).

> Improve SegmentReader.getXXXDocValues
> -------------------------------------
>
>                 Key: LUCENE-5683
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5683
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Assignee: Robert Muir
>
> Today we do two hash lookups, where in most cases a single one is enough. E.g. SR.getNumericDocValues
initializes the FieldInfo (first lookup in FieldInfos), however if that field was already
initialized, we can simply check dvFields.get(). This can be improved in all getXXXDocValues
as well as getDocsWithField.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message