lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5683) Improve SegmentReader.getXXXDocValues
Date Thu, 22 May 2014 08:44:40 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005729#comment-14005729
] 

Shai Erera commented on LUCENE-5683:
------------------------------------

I've thought about it more ... I really don't see the two hash lookups as an inefficiency,
especially considering that if you're pulling a DocValues, you probably going to iterate over
docs' values which is way more expensive than a hash lookup. And the code is safe, as otherwise
the test failures prove. I'll resolve as Won't Fix for now, if we want to revisit in the future,
we can reopen.

> Improve SegmentReader.getXXXDocValues
> -------------------------------------
>
>                 Key: LUCENE-5683
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5683
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>
> Today we do two hash lookups, where in most cases a single one is enough. E.g. SR.getNumericDocValues
initializes the FieldInfo (first lookup in FieldInfos), however if that field was already
initialized, we can simply check dvFields.get(). This can be improved in all getXXXDocValues
as well as getDocsWithField.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message