lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <>
Subject [jira] [Updated] (LUCENE-5701) Move core closed listeners to AtomicReader
Date Fri, 23 May 2014 15:09:02 GMT


Adrien Grand updated LUCENE-5701:

    Attachment: LUCENE-5701.patch

Here is a patch:
 * add/removeCoreClosedListener is abstract on AtomicReader
 * SegmentReader keeps doing the same thing
 * FilterAtomicReader delegates the call
 * Composite implementations ({{ParallelAtomicReader}}, {{SlowCompositeReaderWrapper}}) and
implementations that don't have a core ({{MemoryIndexReader}}) call the listener upon closing.

> Move core closed listeners to AtomicReader
> ------------------------------------------
>                 Key: LUCENE-5701
>                 URL:
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 4.9, 5.0
>         Attachments: LUCENE-5701.patch
> Core listeners are very helpful when managing per-segment caches (filters, uninverted
doc values, etc.) yet this API is only exposed on {{SegmentReader}}. If you want to use it
today, you need to do instanceof checks, try to unwrap in case of a FilterAtomicReader and
finally fall back to a reader closed listener if every other attempt to get the underlying
SegmentReader failed.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message