lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <>
Subject [jira] [Updated] (LUCENE-5701) Move core closed listeners to AtomicReader
Date Fri, 23 May 2014 17:03:02 GMT


Adrien Grand updated LUCENE-5701:

    Attachment: LUCENE-5701.patch

Good catch, I had missed that SCRW didn't return this as a cache key. Here is a new patch,
I made the {{IndexReader}} on which to apply the close listener explicit in {{addCoreClosedListenerAsReaderClosedListener}}
and modified the test to make sure the listener is added to the wrapped reader.

> Move core closed listeners to AtomicReader
> ------------------------------------------
>                 Key: LUCENE-5701
>                 URL:
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 4.9, 5.0
>         Attachments: LUCENE-5701.patch, LUCENE-5701.patch
> Core listeners are very helpful when managing per-segment caches (filters, uninverted
doc values, etc.) yet this API is only exposed on {{SegmentReader}}. If you want to use it
today, you need to do instanceof checks, try to unwrap in case of a FilterAtomicReader and
finally fall back to a reader closed listener if every other attempt to get the underlying
SegmentReader failed.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message