lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Thacker (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-6119) TestReplicationHandler attempts to remove open folders
Date Fri, 30 May 2014 07:35:02 GMT

     [ https://issues.apache.org/jira/browse/SOLR-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Varun Thacker updated SOLR-6119:
--------------------------------

    Attachment: SOLR-6119.patch

Hi Dawid,

Thanks for tracking that down. Yes that does seem to be the problem.

Looks like we should not be deleting the directories in the finally block if it is a named
snapshot. We delete in as part of the test. Attached a patch which changes that.

All of this is looking very fragile and looking at SOLR-6117 it does look like ReplicationHandler
needs a overhaul.

> TestReplicationHandler attempts to remove open folders
> ------------------------------------------------------
>
>                 Key: SOLR-6119
>                 URL: https://issues.apache.org/jira/browse/SOLR-6119
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Priority: Minor
>         Attachments: SOLR-6119.patch, SOLR-6119.patch, SOLR-6119.patch, SOLR-6119.patch
>
>
> TestReplicationHandler has a weird logic around the 'snapDir' variable. It attempts to
remove snapshot folders, even though they're not closed yet. My recent patch uncovered the
bug but I don't know how to fix it cleanly -- the test itself seems to be very fragile (for
example I don't understand the 'namedBackup' variable which is always set to true, yet there
are conditionals around it).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message