lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Commented] (LUCENE-5714) Improve tests for BBoxStrategy then port to 4x.
Date Fri, 20 Jun 2014 10:04:25 GMT


Robert Muir commented on LUCENE-5714:

This isn't going to make 4.9

> Improve tests for BBoxStrategy then port to 4x.
> -----------------------------------------------
>                 Key: LUCENE-5714
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 4.9
>         Attachments: LUCENE-5714__Enhance_BBoxStrategy__more_tests,_fix_dateline_bugs,_new_AreaSimilarity_algor.patch
> BBoxStrategy needs better tests before I'm comfortable seeing it in 4x.  Specifically
it should use random rectangles based validation (ones that may cross the dateline), akin
to the other tests.  And I think I see an equals/hashcode bug to be fixed in there too.
> One particular thing I'd like to see added is how to handle a zero-area case for AreaSimilarity.
 I think an additional feature in which you declare a minimum % area (relative to the query
shape) would be good.
> It should be possible for the user to combine rectangle center-point to query shape center-point
distance sorting as well.  I think it is but I need to make sure it's possible without _having_
to index a separate center point field.
> Another possibility (probably not to be addressed here) is a minimum ratio between width/height,
perhaps 10%.  A long but nearly no height line should not be massively disadvantaged relevancy-wise
to an equivalently long diagonal road that has a square bbox.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message