lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
Date Wed, 02 Jul 2014 08:18:25 GMT

     [ https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shalin Shekhar Mangar updated SOLR-5768:
----------------------------------------

    Attachment: SOLR-5768.diff

It's probably better to use rb.rsp.getReturnFields() because that is set in the prepare method
and it takes care of missing "fl" parameter as well. Otherwise we get a NPE in updateFl method.
This patch fixes that problem.

I also added a test to assert that response returned from distrib and distrib.singlePass method
are the same. I think this is ready.

> Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip
GET_FIELDS
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-5768
>                 URL: https://issues.apache.org/jira/browse/SOLR-5768
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 4.9, 5.0
>
>         Attachments: SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff,
SOLR-5768.diff
>
>
> Suggested by Yonik on solr-user:
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html
> {quote}
> Although it seems like it should be relatively simple to make it work
> with other fields as well, by passing down the complete "fl" requested
> if some optional parameter is set (distrib.singlePass?)
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message