lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-5768) Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip GET_FIELDS
Date Wed, 02 Jul 2014 13:04:24 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049881#comment-14049881
] 

Shalin Shekhar Mangar edited comment on SOLR-5768 at 7/2/14 1:02 PM:
---------------------------------------------------------------------

The last patch had a bug where if uniqueKey was omitted from the "fl" param then you'd get
a NPE in mergeIds.

This patch adds the uniqueKey field if not requested to the individual shard requests so that
we can always merge the shard responses.

Edit - I have added tests using debug=track which assert that indeed this optimization works
and that no shard requests are sent in the GET_FIELDS stage when using this param and the
automatic optimization added in SOLR-1880


was (Author: shalinmangar):
The last patch had a bug where if uniqueKey was omitted from the "fl" param then you'd get
a NPE in mergeIds.

This patch adds the uniqueKey field if not requested to the individual shard requests so that
we can always merge the shard responses.

> Add a distrib.singlePass parameter to make EXECUTE_QUERY phase fetch all fields and skip
GET_FIELDS
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-5768
>                 URL: https://issues.apache.org/jira/browse/SOLR-5768
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 4.9, 5.0
>
>         Attachments: SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff, SOLR-5768.diff,
SOLR-5768.diff, SOLR-5768.diff
>
>
> Suggested by Yonik on solr-user:
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg95045.html
> {quote}
> Although it seems like it should be relatively simple to make it work
> with other fields as well, by passing down the complete "fl" requested
> if some optional parameter is set (distrib.singlePass?)
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message