lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-5790) MutableValue compareTo impls seem to be broken for exists==false
Date Fri, 04 Jul 2014 00:18:35 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man updated LUCENE-5790:
-----------------------------

    Attachment: LUCENE-5790.patch

updated patch:
* continues along assumption of the previous patch (that callers who set exist=false must
reset value to default) per yonik's comments
* adds class level javadocs explaining this expecation of the caller
* adds additional tests of each type of MutableValue
* in addition to yonik's MutableValueDouble fix from the previous patch, this also includes
Ebisawa's MutableValueBool fix.
* Also includes a randomized solr grouping test that heavily stresses docs with missing values
in the grouping fields, and demonstrates both of the bugs Ebisawa mentioned in his email (w/o
the fixes of course)


I think this is ready to commit.

> MutableValue compareTo impls seem to be broken for exists==false
> ----------------------------------------------------------------
>
>                 Key: LUCENE-5790
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5790
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: LUCENE-5790.patch, LUCENE-5790.patch, LUCENE-5790.patch
>
>
> On the solr-user mailing list, Ebisawa & Alex both commented that they've noticed
bugs in the grouping code when some documents don't have values in the grouping field.
> In Ebisawa's case, he tracked this down to what appears to be some bugs in the logic
of the "compareSameType" method of some of the MutableValue implementations.
> Thread: https://mail-archives.apache.org/mod_mbox/lucene-solr-user/201406.mbox/%3C84f86fce4b8f42268048aecfb2806a8c@SIXPR04MB045.apcprd04.prod.outlook.com%3E



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message