lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Littlestar (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-5801) Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader
Date Sat, 19 Jul 2014 16:47:38 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067583#comment-14067583
] 

Littlestar edited comment on LUCENE-5801 at 7/19/14 4:45 PM:
-------------------------------------------------------------

I test again.

this bug only occur when there is another BinaryDocValue field.
two field: FacetField + BinaryDocValuesField 

when I remove the BinaryDocValuesField, tested ok.

I checked OrdinalMappingAtomicReader, there is no check FacetField ?

I think getBinaryDocValues is wrong in 4.10.0
in 4.6.1, it check field in dvFieldMap.

in 4.6.1
 @Override
  public BinaryDocValues getBinaryDocValues(String field) throws IOException {
    BinaryDocValues inner = super.getBinaryDocValues(field);
    if (inner == null) {
      return inner;
    }
    
    CategoryListParams clp = dvFieldMap.get(field);
    if (clp == null) {
      return inner;
    } else {
      return new OrdinalMappingBinaryDocValues(clp, inner);
    }
  }



was (Author: cnstar9988):
I test again.

this bug only occur when there is another BinaryDocValue field.
two field: FacetField + BinaryDocValuesField 

when I remove the BinaryDocValuesField, tested ok.

I checked OrdinalMappingAtomicReader, there is no differ between normal BinaryDocValuesField
 or FacetField ??

> Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader
> -----------------------------------------------------------------
>
>                 Key: LUCENE-5801
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5801
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.7
>            Reporter: Nicola Buso
>            Assignee: Shai Erera
>             Fix For: 5.0, 4.10
>
>         Attachments: LUCENE-5801.patch, LUCENE-5801.patch, LUCENE-5801_1.patch, LUCENE-5801_2.patch
>
>
> from lucene > 4.6.1 the class:
> org.apache.lucene.facet.util.OrdinalMappingAtomicReader
> was removed; resurrect it because used merging indexes related to merged taxonomies.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message