lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-6281) PostingsSolrHighlighter should be more configurable
Date Mon, 28 Jul 2014 21:09:39 GMT

     [ https://issues.apache.org/jira/browse/SOLR-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Smiley updated SOLR-6281:
-------------------------------

    Attachment: SOLR-6281_PostingsSolrHighlighter_more_configurable.patch

In the attached patch, I made the anonymous inner class non-anonymous "SolrExtendedPostingsHighlighter"
(so that it can be extended) and instantiated via a new method getHighlighter(req) that can
be overridden.  And I made a minor refactoring to reduce indentation levels, plus added a
TODO as I observed this highlighter does not use the logic in DefaultSolrHighlighter.alternateField().

I'll commit this in a couple days.

> PostingsSolrHighlighter should be more configurable
> ---------------------------------------------------
>
>                 Key: SOLR-6281
>                 URL: https://issues.apache.org/jira/browse/SOLR-6281
>             Project: Solr
>          Issue Type: Improvement
>          Components: highlighter
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 5.0, 4.10
>
>         Attachments: SOLR-6281_PostingsSolrHighlighter_more_configurable.patch
>
>
> The DefaultSolrHighlighter (works on non-FVH and FVH modes) and PostingsSolrHighlighter
are quite different, although they do share some highlighting parameters where it's directly
applicable.  DSH has its fragListBuilder, fragmentsBuilder, boundaryScanner, configurable
by letting you defined your own class in solrconfig.xml.  PSH does not; it uses the Lucene
default implementations of DefaultPassageFormatter, PassageScorer, and Java BreakIterator,
though it configures each of them based on options. I have a case where I need to provide
a custom PassageFormatter, for example.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message