lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5850) Constants#LUCENE_MAIN_VERSION can have broken values
Date Mon, 28 Jul 2014 17:52:40 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076467#comment-14076467
] 

Michael McCandless commented on LUCENE-5850:
--------------------------------------------

Well, in 4.8.1 CheckIndex doesn't print out SI's version, so smokeTestRelease.py gets upset:

{noformat}
Traceback (most recent call last):
  File "dev-tools/scripts/smokeTestRelease.py", line 1360, in <module>
  File "dev-tools/scripts/smokeTestRelease.py", line 1304, in main
  File "dev-tools/scripts/smokeTestRelease.py", line 1341, in smokeTest
  File "dev-tools/scripts/smokeTestRelease.py", line 637, in unpackAndVerify
  File "dev-tools/scripts/smokeTestRelease.py", line 764, in verifyUnpacked
  File "dev-tools/scripts/smokeTestRelease.py", line 948, in testDemo
RuntimeError: unable to locate version=NNN output from CheckIndex; see checkindex.log
{noformat}

> Constants#LUCENE_MAIN_VERSION can have broken values 
> -----------------------------------------------------
>
>                 Key: LUCENE-5850
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5850
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: general/build
>    Affects Versions: 4.3.1, 4.5.1
>            Reporter: Simon Willnauer
>             Fix For: 5.0, 4.10
>
>         Attachments: LUCENE-5850.patch, LUCENE-5850_bomb.patch, LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should not contain
minor versions. Well this is at least what I thought and to my knowledge what the comments
say too. Yet in for instance 4.3.1 and 4.5.1 we broke this such that the version from SegmentsInfo
can not be parsed with Version#parseLeniently. IMO we should really add an assertion that
this constant doesn't throw an error and / or make the smoketester catch this. to me this
is actually a index BWC break. Note that 4.8.1 doesn't have this problem...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message