lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-5850) Constants#LUCENE_MAIN_VERSION can have broken values
Date Tue, 29 Jul 2014 13:34:38 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077703#comment-14077703
] 

Uwe Schindler edited comment on LUCENE-5850 at 7/29/14 1:32 PM:
----------------------------------------------------------------

There is nothing complicated anymore. As I said, I can fix the test. We already have splitted
the common-build.xml version numbers in the base version and the appendix. The testcase just
has to check if the base version is identical to the LUCENE_MAIN_VERSION constant. We are
on the safe side then. The user can change the appendix as he likes (jenkins does this at
the moment). The problem is just our test configuraton, I will provide a patch once I am back
at home, just give me one or 2 days :-) It is all supported, just the testcase is bullshit
- and I will fix this.


was (Author: thetaphi):
There is nothing complicated anymore. As I said, I can fix the test. We already have splitted
the common-build.xml version numbers in the base version and the appendix. The testcase just
has to check if the base version is identical to the LUCENE_MAIN_VERSION constant. We are
on the safe side then. The user can change the appendix as he likes (chenckins does this at
the moment). The problem is just our test configuraton, I will provide a patch once I am back
at home, just give me one or 2 days :-) It is all supported, just the testcase is bullshit
- and I will fix this.

> Constants#LUCENE_MAIN_VERSION can have broken values 
> -----------------------------------------------------
>
>                 Key: LUCENE-5850
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5850
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: general/build
>    Affects Versions: 4.3.1, 4.5.1
>            Reporter: Simon Willnauer
>             Fix For: 5.0, 4.10
>
>         Attachments: LUCENE-5850.patch, LUCENE-5850_bomb.patch, LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should not contain
minor versions. Well this is at least what I thought and to my knowledge what the comments
say too. Yet in for instance 4.3.1 and 4.5.1 we broke this such that the version from SegmentsInfo
can not be parsed with Version#parseLeniently. IMO we should really add an assertion that
this constant doesn't throw an error and / or make the smoketester catch this. to me this
is actually a index BWC break. Note that 4.8.1 doesn't have this problem...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message