lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5850) Constants#LUCENE_MAIN_VERSION can have broken values
Date Wed, 30 Jul 2014 11:32:38 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079198#comment-14079198
] 

Robert Muir commented on LUCENE-5850:
-------------------------------------

{quote}
To support ALPHA/BETA versions (like Robert introduced in 4.0-ALPHA), you can set a boolean
to true in Constants.java. By that it automatically appends ".0.1" at the end of the MAIN_VERSION.
{quote}

But thats not what we did. Alpha, Beta, and Final all had 3 distinct version numbers. 

{quote}
I changed Version.parseLeniently() to allow minor bugfix versions given (so users can write
"4.9.1" into their config files, but its parsed to LUCENE_4_9), which would be the corresponding
match version constant
{quote}

Why not just merge with Version.java to eliminate yet-another-version? We still have too many,
and this is still asking for bugs, just different types of bugs. We can just add the previous
release constants to the enum.

> Constants#LUCENE_MAIN_VERSION can have broken values 
> -----------------------------------------------------
>
>                 Key: LUCENE-5850
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5850
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: general/build
>    Affects Versions: 4.3.1, 4.5.1
>            Reporter: Simon Willnauer
>             Fix For: 5.0, 4.10
>
>         Attachments: LUCENE-5850.patch, LUCENE-5850.patch, LUCENE-5850_bomb.patch, LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should not contain
minor versions. Well this is at least what I thought and to my knowledge what the comments
say too. Yet in for instance 4.3.1 and 4.5.1 we broke this such that the version from SegmentsInfo
can not be parsed with Version#parseLeniently. IMO we should really add an assertion that
this constant doesn't throw an error and / or make the smoketester catch this. to me this
is actually a index BWC break. Note that 4.8.1 doesn't have this problem...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message