lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6290) CollectionsAPIAsyncDistributedZkTest failure
Date Mon, 28 Jul 2014 19:18:38 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076635#comment-14076635
] 

Shalin Shekhar Mangar commented on SOLR-6290:
---------------------------------------------

bq. When developers make future changes, it will often cause tests to fail. If those tests
take 5 minutes to fail when they could take 30 seconds or even a minute, it's very painful.
I've experienced it. Even with my fast computer - in fact computer speed makes little to no
difference in this case.

I totally get that but I'd rather have a test which fails late sometimes (when someone made
a mistake and introduced a bug) than a test which gives up quickly and causes spurious failures
often on our jenkins instance, the results of which are broadcasted to our whole dev community.
We can agree to disagree.

bq.  If there's any other way (a http ping request for status or something like this) then
spin-looping this for 30 seconds without any progress is I think an indication of a real problem.

This. That's exactly the problem here. We're not sleeping for 5 minutes. We are willing to
wait for upto 5 minutes (we can tune it lower if it makes people happier) for an async task
to succeed, invoking a ping status call every 1 second. Unfortunately, instead of going over
the technical merits of the patch, we've decided to have a philosophical discussion here.


> CollectionsAPIAsyncDistributedZkTest failure
> --------------------------------------------
>
>                 Key: SOLR-6290
>                 URL: https://issues.apache.org/jira/browse/SOLR-6290
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud, Tests
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 5.0, 4.10
>
>         Attachments: SOLR-6290.patch
>
>
> Found this failure on my local jenkins instance:
> {code}
> Error Message
> CreateCollection task did not complete! expected:<[completed]> but was:<[running]>
> Stacktrace
> org.junit.ComparisonFailure: CreateCollection task did not complete! expected:<[completed]>
but was:<[running]>
> 	at __randomizedtesting.SeedInfo.seed([D4EC4F9D698903B5:550AC1851ED66389]:0)
> 	at org.junit.Assert.assertEquals(Assert.java:125)
> 	at org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest.testSolrJAPICalls(CollectionsAPIAsyncDistributedZkTest.java:75)
> 	at org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest.doTest(CollectionsAPIAsyncDistributedZkTest.java:61)
> 	at org.apache.solr.BaseDistributedSearchTestCase.testDistribSearch(BaseDistributedSearchTestCase.java:865)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message