lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] [Resolved] (SOLR-4406) RawResponseWriter - doesn't use the configured "base" writer.
Date Wed, 03 Sep 2014 19:33:51 GMT


Hoss Man resolved SOLR-4406.
       Resolution: Fixed
    Fix Version/s: 4.11

bq. Personally I prefer having small, self describing test method names...

Well, to me the tests as you had them were too small to really have any context as to what
was going on - i'd rather the individual tests be readable as a "story" (you start with x,
you do y, you expect a, b, and c) ... but yeah, it's largely subjective.

in any case, thank you very much for the patch and the tests!

> RawResponseWriter - doesn't use the configured "base" writer.
> -------------------------------------------------------------
>                 Key: SOLR-4406
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>          Components: Response Writers
>    Affects Versions: 4.0
>            Reporter: Steve Davids
>            Assignee: Hoss Man
>             Fix For: 5.0, 4.11
>         Attachments: SOLR-4406.patch, SOLR-4406.patch, SOLR-4406.patch, SOLR-4406.patch,
SOLR-4406.patch, SOLR-4406.patch
> The RawResponseWriter accepts a configuration value for a "base" ResponseWriter if no
ContentStream can be detected. The line of code is commented out that would allow this secondary
response writer to work. It would be great to uncomment the line and provide an OutputStreamWriter
as the writer argument.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message