lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5952) Give Version parsing exceptions more descriptive error messages
Date Sun, 21 Sep 2014 09:44:33 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142396#comment-14142396
] 

ASF subversion and git services commented on LUCENE-5952:
---------------------------------------------------------

Commit 1626550 from [~mikemccand] in branch 'dev/trunk'
[ https://svn.apache.org/r1626550 ]

LUCENE-5952: better error messages when version fails to parse; use simpler string tokenizer;
don't check major versions at such a low level

> Give Version parsing exceptions more descriptive error messages
> ---------------------------------------------------------------
>
>                 Key: LUCENE-5952
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5952
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.10
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Blocker
>             Fix For: 4.10.1, 5.0, Trunk
>
>         Attachments: LUCENE-5952.patch, LUCENE-5952.patch, LUCENE-5952.patch, LUCENE-5952.patch,
LUCENE-5952.patch, LUCENE-5952.patch
>
>
> As discussed on the dev list, it's spooky how Version.java tries to fully parse the incoming
version string ... and then throw exceptions that lack details about what invalid value it
received, which file contained the invalid value, etc.
> It also seems too low level to be checking versions (e.g. is not future proof for when
4.10 is passed a 5.x index by accident), and seems redundant with the codec headers we already
have for checking versions?
> Should we just go back to lenient parsing?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message