lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5953) Make LockFactory final on Directory
Date Wed, 17 Sep 2014 01:23:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136629#comment-14136629
] 

Robert Muir commented on LUCENE-5953:
-------------------------------------

strong +1.

Lets simplify and make this safer. I agree too, the interaction between Directory and LockFactory
is confusing. 

How can we make this as simple and error-free as possible?

> Make LockFactory final on Directory
> -----------------------------------
>
>                 Key: LUCENE-5953
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5953
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/store
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 5.0
>
>
> We should remove the setters for the LockFactory from Directory and make the field final.
It is a bug to change the LockFactory after creating a directory, because you may break locking
(if locks are currently held).
> The LockFactory should be passed on ctor only.
> The other suggestion: Should LockFactory have a directory at all? We moved away from
having the lock separately from the index directory. This is no longer a supported configuration
(since approx Lucene 2.9 or 3.0). I would like to remove the directory from LockFactory and
make it part of the Directory only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message