lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ramkumar Aiyengar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6571) Need a znode watcher support class
Date Mon, 29 Sep 2014 20:00:34 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152173#comment-14152173
] 

Ramkumar Aiyengar commented on SOLR-6571:
-----------------------------------------

FWIW, I still think this is an interesting idea. SolrZkClient already wraps all watchers,
so probably that should store and fire all watchers on expiry. Most things (except when you
use it to do things like trigger recovery) shouldn't really worry about expiry, having such
code exposes us to rare edge cases which happen only when some zk misconfiguration or issue
happens.

> Need a znode watcher support class
> ----------------------------------
>
>                 Key: SOLR-6571
>                 URL: https://issues.apache.org/jira/browse/SOLR-6571
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Timothy Potter
>
> When implementing SOLR-6249, [~noble.paul] points out that ZkIndexSchemaReader doesn't
watch the managed schema znode correctly and should use a strategy similar to what ZkStateReader
does so that watchers persist across zk client connection failures:
> The correct example is the constructor of ZkStateReader
>    zkClient = new SolrZkClient(zkServerAddress, zkClientTimeout, zkClientConnectTimeout,
>         // on reconnect, reload cloud info
>         new OnReconnect() {
>             //implement stuff here
>          }
>         });
> this ensures that the watchers are persisted across reconnect.
> We need a watch support class to help developers implement watchers correctly instead
of having some code do it correctly and other code not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message