lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cyrille Roy (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
Date Wed, 05 Nov 2014 17:14:34 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198667#comment-14198667
] 

Cyrille Roy edited comment on SOLR-2927 at 11/5/14 5:14 PM:
------------------------------------------------------------

hi [~shalinmangar] I have some questions regarding the patch you provided.
I backported the fix into branch_4_2  and have some test failures.

I updated the patch to have right after the closeHooks (line 1070)
- ExecutorUtil.shutdown.AndAwaitTermination block
- infoRegistry block
With that, I have no more failures.

I wonder if it would be better to wait for searcherExecutor shutdown sooner than later because
this thread can keep on doing some work whereas we are supposed to close the core.
Thanks


was (Author: croy):
hi [~shalinmangar] I have some questions regarding the patch you provided.
I backported the fix into branch_4_2  have some test failures.

I updated the patch to have right after the closeHooks (line 1070)
- ExecutorUtil.shutdown.AndAwaitTermination block
- infoRegistry block
With that, I have no more failures.

I wonder if it would be better to wait for searcherExecutor shutdown sooner than later because
this thread can keep on doing some work whereas we are supposed to close the core.
Thanks

> SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-2927
>                 URL: https://issues.apache.org/jira/browse/SOLR-2927
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 4.0-ALPHA
>         Environment: JDK1.6/CentOS
>            Reporter: tom liu
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-2927.patch, mbean-leak-jira.png
>
>
> # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher
method remove name of currentSearcher on infoRegistry.
> # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's
close do not remove the name of cache.
> so, there maybe lost some memory leak.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message