lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6082) only IndexFileDeleter should delete files
Date Sun, 30 Nov 2014 10:12:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229063#comment-14229063
] 

Michael McCandless commented on LUCENE-6082:
--------------------------------------------

+1

This change is a little strange:

{noformat}
+      // next event will cause IW to delete the old files: we use prepareCommit just as example
+      iw.prepareCommit();
{noformat}

Without this, was the test leaving deletable but not deleted files in the index (failing that
counter check)?  Why wasn't IW deleting the partially written files on hitting the IAE?

> only IndexFileDeleter should delete files
> -----------------------------------------
>
>                 Key: LUCENE-6082
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6082
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-6082.patch
>
>
> Currently the codec API has SI writers, stored fields writers, and term vectors writers
all deleting files, Stored fields and term vectors codec APIs have abort() methods, etc.
> This is outdated and scary, since TrackingDirectoryWrapper is used to the list of files
the codec used, and this is ultimately passed to IndexFileDeleter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message