lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6780) Merging request parameters with defaults produce duplicate entries
Date Mon, 01 Dec 2014 18:10:13 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230159#comment-14230159
] 

ASF subversion and git services commented on SOLR-6780:
-------------------------------------------------------

Commit 1642727 from hossman@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1642727 ]

SOLR-6780: Fixed a bug in how default/appends/invariants params were affecting the set of
all keys found in the request parameters, resulting in some key=value param pairs being duplicated.

> Merging request parameters with defaults produce duplicate entries
> ------------------------------------------------------------------
>
>                 Key: SOLR-6780
>                 URL: https://issues.apache.org/jira/browse/SOLR-6780
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.1, 5.0, Trunk
>            Reporter: Alexandre Rafalovitch
>            Assignee: Hoss Man
>              Labels: parameters
>             Fix For: 4.10.3, 5.0, Trunk
>
>         Attachments: SOLR-6780.patch
>
>
> When a parameter (e.g. echoParams) is specified and overrides the default on the handler,
it actually generates two entries for that key with the same value. 
> Most of the time it is just a confusion and not an issue, however, some components will
do the work twice. For example faceting component as described in http://search-lucene.com/m/QTPaSlFUQ1/duplicate
> It may also be connected to SOLR-6369
> The cause seems to be the interplay between *DefaultSolrParams#getParameterNamesIterator()*
which just returns param names in sequence and *SolrParams#toNamedList()* which uses the first
(override then default) value for each key, without deduplication.
> It's easily reproducible in trunk against schemaless example with 
> bq. curl "http://localhost:8983/solr/schemaless/select?indent=true&echoParams=all"
> I've also spot checked it and it seems to be reproducible back to Solr 4.1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message