lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6085) Add back SI.attributes (safely)
Date Mon, 01 Dec 2014 16:46:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230019#comment-14230019
] 

Michael McCandless commented on LUCENE-6085:
--------------------------------------------

+1

> Add back SI.attributes (safely)
> -------------------------------
>
>                 Key: LUCENE-6085
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6085
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6085.patch
>
>
> We removed this for two reasons:
> * nothing was using it
> * the map is "unsafe" if a codec tried to write to it during in-place dv update.
> But Adrien has a real use case (LUCENE-5914), and I think we can just add some safety
for the updates case (e.g. if the map is unmodifiable then the trap will not exist, any put()
will throw exception). In general, we should have more safety in SI anyway (diagnostics map,
too).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message