lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6895) Consider renaming SolrServer to SolrClient
Date Mon, 29 Dec 2014 15:56:13 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260173#comment-14260173
] 

Alan Woodward commented on SOLR-6895:
-------------------------------------

I think if we're going over a major version change (4 -> 5), we don't need to worry about
binary compatibility here?  Anybody upgrading will immediately get compiler errors, and there
will be an entry in CHANGES.txt that says "SolrServer is renamed to SolrClient", etc.

EmbeddedSolrServer should probably become something like EmbeddedServerSolrClient.  Doesn't
exactly trip off the tongue, but it describes what it does :-)

There are a bunch of other SolrJ changes and cleanups I'd like to get in for 5.0.  Mainly,
as I'm working on SOLR-6840, I'm trying to get more of our tests to use SolrJ, which exposes
shortcomings in the API pretty quickly.  I'll create issues as I come across them.

> Consider renaming SolrServer to SolrClient
> ------------------------------------------
>
>                 Key: SOLR-6895
>                 URL: https://issues.apache.org/jira/browse/SOLR-6895
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>    Affects Versions: 5.0, Trunk
>            Reporter: Alan Woodward
>            Priority: Minor
>
> This has been niggling at me for a while.  Instantiating a new SolrServer object doesn't
create a server, it creates a client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message