lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6895) Consider renaming SolrServer to SolrClient
Date Mon, 29 Dec 2014 16:57:14 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260220#comment-14260220
] 

Yonik Seeley commented on SOLR-6895:
------------------------------------

bq. If a client has SolrJ embedded, then it's got a specifically versioned JAR file in it
somewhere that it's compiled against. At the moment, there aren't any changes to the SolrJ
wire protocol, so clients embedding a 4.x jar will still work.

Correct, this is what I was talking about when I wrote:
bq. There's probably a ton of code out there that uses SolrJ though - so we should strive
to either keep SolrJ4 clients compatible with Solr5

bq. If a client wants to upgrade the jar file, then they have to edit their source and recompile,
but I think that's expected when going over a major version bump?

Yes, but we can make that easier or harder.  Being a client interface, we should normally
still strive for compatibility (in general), and think about how to make everyone's life easier
when we do make changes.  There's no hard-n-fast rules - we should do what makes the most
sense.

> Consider renaming SolrServer to SolrClient
> ------------------------------------------
>
>                 Key: SOLR-6895
>                 URL: https://issues.apache.org/jira/browse/SOLR-6895
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>    Affects Versions: 5.0, Trunk
>            Reporter: Alan Woodward
>            Priority: Minor
>
> This has been niggling at me for a while.  Instantiating a new SolrServer object doesn't
create a server, it creates a client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message