lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6146) Directory.copy -> Directory.copyFrom
Date Thu, 01 Jan 2015 15:16:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262573#comment-14262573
] 

ASF subversion and git services commented on LUCENE-6146:
---------------------------------------------------------

Commit 1648851 from [~rcmuir] in branch 'dev/trunk'
[ https://svn.apache.org/r1648851 ]

LUCENE-6146: Replaced Directory.copy() with Directory.copyFrom()

> Directory.copy -> Directory.copyFrom
> ------------------------------------
>
>                 Key: LUCENE-6146
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6146
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: core/store
>            Reporter: Robert Muir
>             Fix For: 5.0, Trunk
>
>         Attachments: LUCENE-6146.patch
>
>
> Spinoff of LUCENE-4746.
> This method is currently:
> {code}
> copy(Directory to, String src, String dest, IOContext context)
> {code}
> But it would be better to restructure this so the destination directory is the one actually
being changed by the operation:
> {code}
> copyFrom(Directory from, String src, String dest, IOContext context)
> {code}
> Besides fixing the order to make sense, adding it to the name might help prevent bugs
like the current TrackingDirectoryWrapper impl (used by IndexWriter to track what files are
used):
> {code}
> public void copy(Directory to, String src, String dest, IOContext context) throws IOException
{
>   createdFileNames.add(dest); // BUG!
>   in.copy(to, src, dest, context);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message