lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (LUCENE-6150) Remove staleFiles set from FSDirectory
Date Thu, 01 Jan 2015 10:46:13 GMT


ASF subversion and git services commented on LUCENE-6150:

Commit 1648813 from [~thetaphi] in branch 'dev/branches/branch_5x'
[ ]

Merged revision(s) 1648812 from lucene/dev/trunk:
LUCENE-6150: Remove staleFiles set and onIndexOutputClosed() from FSDirectory

> Remove staleFiles set from FSDirectory
> --------------------------------------
>                 Key: LUCENE-6150
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: core/store
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 5.0, Trunk
>         Attachments: LUCENE-6150.patch
> Hi,
> the "hack" to keep track of files written to in FSDirectory, to filter them when calling
sync is heavily broken. [~mikemccand] already opened an issue, which was abandoned then.
> In fact handling this in FSDirectory is a hack and broken! If IndexWriter is itsself
not able to correctly handle tracking the files, it is also his repsonsibilty to do this.
We already have a class that can do this: TrackingDirectoryWrapper. IndexWriter should use
an instance of this class to track those stale files (until the problem is solved).
> I would like to keep FSDirectory clean from this, especially, as this is broken anyways:
If somebody has another directory impl like HDFS or Infinispan, the problem still persists.
The base directory should throw an IOException if trying to sync a file that does not exist!

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message