lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomás Fernández Löbbe (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-6954) Considering changing SolrClient#shutdown to SolrClient#close.
Date Wed, 21 Jan 2015 21:38:35 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286322#comment-14286322
] 

Tomás Fernández Löbbe commented on SOLR-6954:
---------------------------------------------

I think it's better if close delegates in shutdown for now, that way if someone has extended
shutdown their code would still work. 

> Considering changing SolrClient#shutdown to SolrClient#close.
> -------------------------------------------------------------
>
>                 Key: SOLR-6954
>                 URL: https://issues.apache.org/jira/browse/SOLR-6954
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-6954.patch
>
>
> SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want users to release
these objects, close is more standard and if we implement Closeable, tools help point out
leaks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message