lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elyograg <...@git.apache.org>
Subject [GitHub] lucene-solr pull request: Branch 3x
Date Thu, 12 Feb 2015 13:56:35 GMT
Github user elyograg commented on the pull request:

    https://github.com/apache/lucene-solr/pull/128#issuecomment-74073810
  
    I don't think this is going to happen, for a few reasons:
    
    1) branch_3x no longer exists in the current repositories.  Neither does branch_4x.  The
current stable development branch is branch_5x.
    
    2) The 3x branch was deleted a LONG time ago.  The amount of change in trunk since then
is *enormous*, so the merging will NOT be clean.  Conflict resolution will be manual and very
tedious.
    
    3) Almost all commits on a stable branch like branch_3x are already in trunk, because
that's how we do development - changes are applied to trunk and then backported to whatever
the stable branch is at the time.  I would be willing to bet that almost all of the changes
you have listed here are already in trunk.  This fact probably causes even more merge conflicts
than the age of branch_3x, and means that most of these changes are completely unnecessary.
    
    4) This patch is HUGE.  Nobody will agree to merge anything unless it makes a discrete
change that can be easily analyzed to determine what's being done and how it benefits the
project.  Very large changes must be broken up into much smaller changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message