lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5833) Suggestor Version 2 doesn't support multiValued fields
Date Sat, 28 Feb 2015 16:20:05 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341618#comment-14341618
] 

Erick Erickson commented on LUCENE-5833:
----------------------------------------

[~mikemccand] Truth be told I haven't looked at it yet. Kind of waiting for the 4.10.4 tag
to be set before getting too far into this.

Of the 4 suggester-related things I marked for putting in 4.10.5, this is the one I could
be most easily convinced to leave out. I'll look a bit more deeply, but I'll almost certainly
defer to your expertise here.

The other three JIRAs are either very low-risk (the bit about requiring weightField in solrconfig.xml
configuration) or make using the Suggester stuff from Solr unworkable for a large corpus,
so I'm willing to argue about those. This one kind of snuck in there by chance though.

At least with Jan's work, we have a viable alternative for people on 4.x that MUST have this
functionality, "apply the patch and go". And if that isn't possible, construct the field up-front
so it's not multiValued.

Hmmm, I'm pretty much convincing myself to not put this in 4.10.5. Although I'll go for trunk
and 5x.

Thanks! It's always great to have an informed viewpoint!

> Suggestor Version 2 doesn't support multiValued fields
> ------------------------------------------------------
>
>                 Key: LUCENE-5833
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5833
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/other
>    Affects Versions: 4.8.1
>            Reporter: Greg Harris
>            Assignee: Erick Erickson
>             Fix For: 4.10.4, 5.0, Trunk
>
>         Attachments: LUCENE-5833.patch, LUCENE-5833.patch, LUCENE-5833.patch, LUCENE-5833_branch4_10.patch,
SOLR-6210.patch
>
>
> So if you use a multiValued field in the new suggestor it will not pick up terms for
any term after the first one. So it treats the first term as the only term it will make it's
dictionary from. 
> This is the suggestor I'm talking about:
> https://issues.apache.org/jira/browse/SOLR-5378



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message