lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-6919) Log REST info before executing
Date Tue, 03 Feb 2015 16:20:35 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303515#comment-14303515
] 

Mike Drob edited comment on SOLR-6919 at 2/3/15 4:20 PM:
---------------------------------------------------------

I checked out {{IndexWriter}} and {{InfoStream}} and think it might be somewhat overengineered
for this case.

How about we just create a child logger and use that? Then it will inherit the default levels
and settings from the SolrCore logger, or can be set separately if desired. I've attached
another patch with this if we think this is a good path to go.


was (Author: mdrob):
I checked out {IndexWriter}} and {{InfoStream}} and think it might be somewhat overengineered
for this case.

How about we just create a child logger and use that? Then it will inherit the default levels
and settings from the SolrCore logger, or can be set separately if desired. I've attached
another patch with this if we think this is a good path to go.

> Log REST info before executing
> ------------------------------
>
>                 Key: SOLR-6919
>                 URL: https://issues.apache.org/jira/browse/SOLR-6919
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: Mike Drob
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: Trunk, 5.1
>
>         Attachments: SOLR-6919.patch, SOLR-6919.patch, SOLR-6919.patch, SOLR-6919.patch
>
>
> We should log request info (path, parameters, etc...) before attempting to execute a
query. This is helpful in cases where we get a bad query that causes OOM or something else
catastrophic, and are doing post-event triage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message