lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory Chanan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7033) RecoveryStrategy should not publish any state when closed / cancelled.
Date Mon, 09 Feb 2015 23:05:35 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313101#comment-14313101
] 

Gregory Chanan commented on SOLR-7033:
--------------------------------------

{code}if (lastActionStartedAt == 0) {
{code}

Probably unlikely to happen, but I believe the call to nanoTime could return any value, even
0.  So it's possible you could markAttemptingAction and then all calls to minimumWaitBetweenActions
just return.

> RecoveryStrategy should not publish any state when closed / cancelled.
> ----------------------------------------------------------------------
>
>                 Key: SOLR-7033
>                 URL: https://issues.apache.org/jira/browse/SOLR-7033
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Blocker
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-7033.patch, SOLR-7033.patch, SOLR-7033.patch, SOLR-7033.patch
>
>
> Currently, when closed / cancelled, RecoveryStrategy can publish a recovery failed state.
In a bad loop (like when no one can become leader because no one had a last state of active)
this can cause very fast looped publishing of this state to zk.
> It's an outstanding item to improve that specific scenario anyway, but regardless, we
should fix the close / cancel path to never publish any state to zk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message