lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6234) harden smokeTestRelease.py's expectations regarding CWD
Date Tue, 10 Feb 2015 18:10:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314559#comment-14314559
] 

Hoss Man commented on LUCENE-6234:
----------------------------------

This may be a red herring -- pretty sure the root error is: LUCENE-6235

my reading of the code is that it's running TestBackwardsCompatibility in the unpacked directory
of a lucene-src release.  I suspect smoke tester doesn't actaully care anywhere about the
CWD that the user initially used to run smokeTestRelease.py ... but i still need to test that.



> harden smokeTestRelease.py's expectations regarding CWD
> -------------------------------------------------------
>
>                 Key: LUCENE-6234
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6234
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Hoss Man
>
> smokeTestRelease.py changed at some point to require/expect that you run it from the
root of the checkout of the branch you are smoke testing, per rernst's comments in mail...
> bq. That part of the script expects you run from the root of a checkout.  It runs the
backcompat tests, and scrapes the test output to check all are tested.
> The context was that i (out of habit from older versions of this script) was trying to
do this in my personal tmp space (expecting the script to create it's RC specific tmp dir
in the CWD)...
> {noformat}
> hossman@frisbee:~/tmp$ python3.2 ~/lucene/branch_5_0/dev-tools/scripts/smokeTestRelease.py
http://people.apache.org/~anshum/staging_area/lucene-solr-5.0.0-RC2-rev1658469
> {noformat}
> If smokeTestRelease.py is going to have expectations about it's CWD, then it should either
enforce those expectations (ie: do a simple assert in main() that the CWD meets some expectations,
and/or check "$0") or it should use "$0" to figure out where the root svn checkout is and
cd to that directory itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message