lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6244) Approximations on disjunctions
Date Sat, 14 Feb 2015 18:29:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321618#comment-14321618
] 

Robert Muir commented on LUCENE-6244:
-------------------------------------

{quote}
The first patch worked like conjunctions, the scorer first advanced the approximation and
then called nextDoc() on the approximation until it found a document that matches. So when
scores were not needed, you could just stop calling "matches()" as soon as one of the clauses
that are positionned on the current doc matches. I don't think it's an important optimization
but was worth mentioning.
{quote}

OK, so it only impacts when scores are not needed. Thanks. I think its ok to defer.

{quote}
I didn't want to optimize anything in particular, but having the freq computed eagerly made
the two-phase view a bit easier to implement. I can try to make it lazy again.
{quote}

Less tricky is better. I just didnt understand the motivation. We can just add a comment that
it simplifies things to do this at the moment? 


> Approximations on disjunctions
> ------------------------------
>
>                 Key: LUCENE-6244
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6244
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: Trunk, 5.1
>
>         Attachments: LUCENE-6244.patch, LUCENE-6244.patch, wikibig.tasks
>
>
> Like we just did on exact phrases and conjunctions, we should also support approximations
on disjunctions in order to apply "matches()" lazily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message