lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7116) Facet refinement shard request should disable other faceting types
Date Fri, 20 Feb 2015 21:17:11 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329564#comment-14329564
] 

Hoss Man commented on SOLR-7116:
--------------------------------

I'm almost certainly wrong.

(I have much more faith in the correctness of comments i put in the code when i wrote it,
then in my own memory of the code)

> Facet refinement shard request should disable other faceting types
> ------------------------------------------------------------------
>
>                 Key: SOLR-7116
>                 URL: https://issues.apache.org/jira/browse/SOLR-7116
>             Project: Solr
>          Issue Type: Improvement
>          Components: faceting
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 5.1
>
>         Attachments: SOLR-7116__facet_refinement_opt.patch
>
>
> While examining FacetComponent in the process of adding the new facet.heatmap faceting
type, I observed that distributed shard refinement requests were built by copying the existing
parameters and then modifying ones pertinent to facet.field or facet.pivot depending on the
type of refinement requests (which in turn only happens some of the time, not too often).
 Those are the only types of faceting that have a refinement phase.  These refinement requests
_should not_ have facet.query, facet.date, facet.range, facet.interval, or facet.heatpmap
since they don't participate in refinement... and furthermore, facet.field and facet.pivot
have their own dedicated refinement requests and so a facet.field request _should not_ have
options for facet.pivot.  But this isn't taken care of, just facet.query is removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message