lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomás Fernández Löbbe (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-7127) Add method to CloudSolrClient to create per-collection clients
Date Sat, 21 Feb 2015 00:55:12 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329870#comment-14329870
] 

Tomás Fernández Löbbe commented on SOLR-7127:
---------------------------------------------

I like this idea, two comments:
* Shouldn't {{public SolrClient getCollectionClient(String collection)}} return a {{CloudSolrClient}}
instead? will the user need CloudSolrClient-specific methods (like {{public void setIdField(String
idField)}} )
* Should we try to deal with actions on the child clients that affect the parents (and all
other created childs), like {{public void setParser(ResponseParser processor)}}

> Add method to CloudSolrClient to create per-collection clients
> --------------------------------------------------------------
>
>                 Key: SOLR-7127
>                 URL: https://issues.apache.org/jira/browse/SOLR-7127
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: SOLR-7127.patch, SOLR-7127.patch
>
>
> CloudSolrClient isn't thread-safe if you're making requests to multiple collections,
because defaultCollection is mutable.  This can be a pain if you're trying to index into multiple
collections from a single queue of documents.
> This issue adds a .getCollectionClient(String) method to CloudSolrClient that returns
a child client directed at that collection.  Under the hood it's another CloudSolrClient sharing
it's resources with the parent client, but with a separate default collection set.  The method
returns a SolrClient, however, so you can't then change the collection unless you explicitly
cast it.
> Sort of related to what I wanted to do on SOLR-6894, but this is more focussed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message