lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Dyer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7144) Suggester dictionary does not set origFreq
Date Tue, 24 Feb 2015 14:24:04 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334914#comment-14334914
] 

James Dyer commented on SOLR-7144:
----------------------------------

Charles,

Here is what I believe how the "correctlySpelled" flag is supposed to work today:

1. If "spellcheck.maxResultsForSuggest" is *not* specified
- If any query term has a frequency of zero, "correctlySpelled" is false.  Otherwise it is
true.

2. If  "spellcheck.maxResultsForSuggest" is specified
- If the query returns fewer results than specified for "spellcheck.maxResultsForSuggest",
"correctlySpelled" is false.  Otherwise it is true.

Were you seeing behavior different from this, or under which cases do you feel "correctlySpelled"
is incorrect that you'd like to change?

Personally, I do not like that "correctlySpelled" even exists.  This is a subjective judgement
and the client can decide this based on # results returned and the contents of the spell check
response.  My approach with this, whenever making changes to the spell check component, is
to try and keep the behavior consistent so nobody upgrades and all of a sudden their app is
broken.  That doesn't mean we can't improve this though, especially if you've found a case
in which its broken.

> Suggester dictionary does not set origFreq
> ------------------------------------------
>
>                 Key: SOLR-7144
>                 URL: https://issues.apache.org/jira/browse/SOLR-7144
>             Project: Solr
>          Issue Type: Bug
>          Components: spellchecker
>    Affects Versions: 4.10.3
>         Environment: Linux, Windows
>            Reporter: Charles Reitzel
>            Priority: Minor
>         Attachments: SOLR-7144.patch
>
>
> Although it sets term frequency for corrections, org.apache.solr.spelling.suggest.Suggester
never sets the frequency for the original term.   Thus, the spellcheck component will never
format extended results.
> There is a related issue with SpellCheckComponent: it may mark a query as correctly spelled,
even if zero frequency terms exist in the original query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message