lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-7145) Make SolrRequest parametrized by its response type
Date Mon, 23 Feb 2015 19:39:12 GMT

     [ https://issues.apache.org/jira/browse/SOLR-7145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alan Woodward updated SOLR-7145:
--------------------------------
    Attachment: SOLR-7145.patch

Patch.

The biggest change is that QueryRequest.process() wasn't declared as throwing IOException,
unlike all the other request types, and was re-packaging them as SolrExceptions.  I think
this is a bug, and it should - you should get a SolrServerException if there's an error on
the server, and an IOException if there's a communication error.

This is a backwards-breaking change, but I think it's an important one to make - swallowing
IOExceptions is just wrong here, and none of the other request types do it.

> Make SolrRequest parametrized by its response type
> --------------------------------------------------
>
>                 Key: SOLR-7145
>                 URL: https://issues.apache.org/jira/browse/SOLR-7145
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: 5.1
>
>         Attachments: SOLR-7145.patch
>
>
> We currently repeat a whole bunch of code in the process() method of every single SolrRequest-derived
class.  We should make SolrRequest parametrized by its response type, and consolidate into
the base class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message