lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SOLR-7151) SolrClient.query() methods should throw IOException
Date Tue, 24 Feb 2015 10:59:04 GMT
Alan Woodward created SOLR-7151:
-----------------------------------

             Summary: SolrClient.query() methods should throw IOException
                 Key: SOLR-7151
                 URL: https://issues.apache.org/jira/browse/SOLR-7151
             Project: Solr
          Issue Type: Bug
          Components: SolrJ
            Reporter: Alan Woodward
            Assignee: Alan Woodward
            Priority: Minor
             Fix For: Trunk, 5.1


All the methods on SolrClient are declared as throwing SolrServerException (thrown if there's
an error somewhere on the server), and IOException (thrown if there's a communication error),
except for the QueryRequest methods.  These swallow up IOException and repackage them in a
SolrServerException.

I think these are useful distinctions to make (you might want to retry on an IOException,
but not on a SolrServerException), and we should make the query methods fall in line with
the others.

I'm not sure if this should go into 5.x as well as trunk, as it's a backwards-breaking change.
 I'm leaning towards yes, as it's a sufficiently useful API change that it's worth the break,
but I'm not going to insist on it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message