lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishan Chattopadhyaya (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7158) ZkConfigManager filesystem fixes for Windows
Date Wed, 25 Feb 2015 11:15:04 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336357#comment-14336357
] 

Ishan Chattopadhyaya commented on SOLR-7158:
--------------------------------------------

Thanks for reviewing, Alan.
The first createDirectories() (on the top) creates the base directory, e.g. c:\users\ishan\configs.

The one I added creates the directories for nested files in the ZK configs, e.g. for a file
in zk: velocity\plain-hit.vm it creates c:\users\ishan\configs\velocity. 

I think the first one (on top) could be removed, since the latter one will recursively create
the base directory as well (something like mkdir -p).

> ZkConfigManager filesystem fixes for Windows
> --------------------------------------------
>
>                 Key: SOLR-7158
>                 URL: https://issues.apache.org/jira/browse/SOLR-7158
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Alan Woodward
>         Attachments: SOLR-7158.patch
>
>
> There were a couple of issues with ZkConfigManager:
> * Directories are not created recursively in Windows with nio.Files.write(). Need to
pre-create the directory structure while downloading config.
> * The separator for zk nodes is '/'. However, on Windows, while uploading the relative
files nested within a directory (e.g. velocity\hit-plain.vm) contain '\'. This, apart from
causing an inconsistency as compared to zk on posix systems, messed up the ZkCLITest on Windows
where count of files in zk and files in the filesystem was compared.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message