lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-7179) JettySolrRunner should not use system properties to pass configuration
Date Sat, 28 Feb 2015 22:18:04 GMT

     [ https://issues.apache.org/jira/browse/SOLR-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alan Woodward updated SOLR-7179:
--------------------------------
    Attachment: SOLR-7179.patch

Patch.

SolrDispatchFilter checks its servlet context for solr home and node properties on init, defaulting
to the usual ways of getting these from sys props if the attributes aren't set.  JettySolrRunner
takes a Properties object as a construction parameter, and the various setXXX methods are
deprecated.  These were trappy anyway, as they only worked if you had a solr.xml or core.properties
set to use specific sysprops.

> JettySolrRunner should not use system properties to pass configuration
> ----------------------------------------------------------------------
>
>                 Key: SOLR-7179
>                 URL: https://issues.apache.org/jira/browse/SOLR-7179
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: SOLR-7179.patch
>
>
> JettySolrRunner sets a bunch of system properties to pass configuration down to its SolrDispatchFilter
and CoreContainer.  This means that we can't launch multiple runners at the same time - sys
props must be set up, the runner launched, we wait for solr to start up, then sys props must
be changed before the next runner can be instantiated.
> Instead we should be able to pass the relevant properties down to SolrDispatchFilter
via the servlet context.  This will allow MiniSolrCloudCluster and the various ZK test cases
to start and stop their jetties in parallel, which will speed up individual tests (and with
luck speed up the test suite overall as well).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message