lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: [DISCUSS] Change Query API to make queries immutable in 6.0
Date Fri, 03 Apr 2015 11:21:18 GMT
On Thu, Apr 2, 2015 at 6:23 PM, Adrien Grand <jpountz@gmail.com> wrote:
> On Fri, Apr 3, 2015 at 12:10 AM, Reitzel, Charles
> <Charles.Reitzel@tiaa-cref.org> wrote:
>> Unfortunately, since boost is used in hashCode() and equals() calculations, changing
the boost will still make the queries "trappy".   You will do all that work to make everything-but-boost
immutable and still not fix the problem.
>
> This is why the query cache clones queries before putting them into
> the cache and sets the boost to 1. The issue is that this clone method
> is only shallow since its purpose is to change the boost. So it works
> fine for the boost parameter but not for eg. boolean clauses.
>
> Again, I don't dismiss advantages of going fully immutable

I will. I do not think it is worth it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message