lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-6271) PostingsEnum should have consistent flags behavior
Date Wed, 01 Apr 2015 15:32:54 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-6271:
--------------------------------
    Attachment: LUCENE-6271.patch

Attached is the latest patch.

Most of the bugs we have found in tests are unrelated to this change... just found by beasting
with nightly=true.

I beasted lucene/core in this branch with 25 runs last night successfully.

> PostingsEnum should have consistent flags behavior
> --------------------------------------------------
>
>                 Key: LUCENE-6271
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6271
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ryan Ernst
>         Attachments: LUCENE-6271.patch, LUCENE-6271.patch
>
>
> When asking for flags like OFFSETS or PAYLOADS with DocsAndPositionsEnum, the behavior
was to always return an enum, even if offsets or payloads were not indexed.  They would just
not be available from the enum if they were not present.  This behavior was carried over to
PostingsEnum, which is good.
> However, the new POSITIONS flag has different behavior.  If positions are not available,
null is returned, instead of a PostingsEnum that just gives access to freqs.  This behavior
is confusing, as it means you have to special case asking for positions (only ask if you know
they were indexed) which sort of defeats the purpose of the unified PostingsEnum.
> We should make POSITIONS have the same behavior as other flags. The trickiest part will
be maintaining backcompat for DocsAndPositionsEnum in 5.x, but I think it can be done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message