lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7325) Change Slice state into enum
Date Mon, 27 Apr 2015 17:56:39 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514543#comment-14514543
] 

ASF subversion and git services commented on SOLR-7325:
-------------------------------------------------------

Commit 1676350 from hossman@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1676350 ]

preemptive cleanup of 'Upgrading' section for 5.2 (SOLR-7325, SOLR-7336, SOLR-4839)

> Change Slice state into enum
> ----------------------------
>
>                 Key: SOLR-7325
>                 URL: https://issues.apache.org/jira/browse/SOLR-7325
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>             Fix For: Trunk, 5.2
>
>         Attachments: SOLR-7325.patch, SOLR-7325.patch, SOLR-7325.patch
>
>
> Slice state is currently interacted with as a string. It is IMO not trivial to understand
which values it can be compared to, in part because the Replica and Slice states are located
in different classes, some repeating same constant names and values.
> Also, it's not very clear when does a Slice get into which state and what does that mean.
> I think if it's an enum, and documented briefly in the code, it would help interacting
with it through code. I don't mind if we include more extensive documentation in the reference
guide / wiki and refer people there for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message