lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SOLR-7325) Change Slice state into enum
Date Wed, 01 Apr 2015 10:31:53 GMT

     [ https://issues.apache.org/jira/browse/SOLR-7325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shai Erera resolved SOLR-7325.
------------------------------
       Resolution: Fixed
    Fix Version/s: 5.2
                   Trunk

Committed to trunk and 5x.

> Change Slice state into enum
> ----------------------------
>
>                 Key: SOLR-7325
>                 URL: https://issues.apache.org/jira/browse/SOLR-7325
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>             Fix For: Trunk, 5.2
>
>         Attachments: SOLR-7325.patch, SOLR-7325.patch, SOLR-7325.patch
>
>
> Slice state is currently interacted with as a string. It is IMO not trivial to understand
which values it can be compared to, in part because the Replica and Slice states are located
in different classes, some repeating same constant names and values.
> Also, it's not very clear when does a Slice get into which state and what does that mean.
> I think if it's an enum, and documented briefly in the code, it would help interacting
with it through code. I don't mind if we include more extensive documentation in the reference
guide / wiki and refer people there for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message