lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6384) remove or fix IndexWriter.tryDeleteDocument
Date Wed, 01 Apr 2015 17:05:52 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390992#comment-14390992
] 

Michael McCandless commented on LUCENE-6384:
--------------------------------------------

bq. At least as a simple improvement, Adrien mentioned we can add RIW.tryDeleteDocument that
returns 'false' sometimes randomly?

+1


> remove or fix IndexWriter.tryDeleteDocument
> -------------------------------------------
>
>                 Key: LUCENE-6384
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6384
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> This method is causing bugs in tests, I think its a trap.
> I don't think people understand the semantics of it, and i don't like that its difficult
for it to return false in tests
> So its unlikely to return false in tests, only in production. Broken just like java 7
string hashing.
> I think we should either remove it, rename it, fix the javadocs let IndexWriter create
a random and intentionally return false from this method say 1% of the time to make it less
trappy, something.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message