lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6420) Update forbiddenapis to 1.8
Date Mon, 20 Apr 2015 15:19:58 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503010#comment-14503010
] 

Uwe Schindler commented on LUCENE-6420:
---------------------------------------

OK, I will commit this in a minute. While sitting in the train to JAX2015, I ran "ant run-maven-build
-DskipTests=true", works (this does basically the same as your command line).

I analyzed the build log and checked the output of forbidden and I was happy, too.

> Update forbiddenapis to 1.8
> ---------------------------
>
>                 Key: LUCENE-6420
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6420
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: Trunk, 5.2
>
>         Attachments: LUCENE-6420-anno.patch, LUCENE-6420-anno.patch, LUCENE-6420-anno.patch,
LUCENE-6420-anno.patch, LUCENE-6420.patch
>
>
> Update forbidden-apis plugin to 1.8:
> - Initial support for Java 9 including JIGSAW
> - Errors are now reported sorted by line numbers and correctly grouped (synthetic methods/lambdas)
> - Package-level forbids: Deny all classes from a package: org.hatedpkg.** (also other
globs work)
> - In addition to file-level excludes, forbiddenapis now supports fine granular excludes
using Java annotations. You can use the one shipped, but define your own, e.g. inside Lucene
and pass its name to forbidden (e.g. using a glob: **.SuppressForbidden would any annotation
in any package to suppress errors). Annotation need to be on class level, no runtime annotation
required.
> This will for now only update the dependency and remove the additional forbid by [~shalinmangar]
for MessageFormat (which is now shipped with forbidden). But we should review and for example
suppress forbidden failures in command line tools using @SuppressForbidden (or similar annotation).
The discussion is open, I can make a patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message